Fix preview deploys for PRs targeting version branches#14066
Merged
Conversation
Preview aliases were being uploaded to the version branch's Worker (e.g. docs-v7) but the preview URL uses *.previews.docs.astro.build which is only configured on the main docs Worker. Override the Worker name to always upload previews to the docs Worker.
❌ Deploy Preview for astro-docs-2 failed. Why did it fail? →
|
|
Preview deployment ✅ Deployment complete!
|
ArmandPhilippot
approved these changes
Jun 15, 2026
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
Member
There was a problem hiding this comment.
I thought this was related to this change on the v7 branch #13872 (comment)
But, well, I'm not a Cloudflare expert... I trust you! 😄
Contributor
Author
|
It's not related, I'll explain there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview deploys for PRs targeting version branches (e.g.
v7) were broken. The deploy succeeded but the preview URL returned 'not found'.Root cause: The
versions upload --preview-aliascommand was using the Worker name fromwrangler.jsoncin the build output. For PRs targetingv7, this uploaded the preview to thedocs-v7Worker, but the preview URL (*.previews.docs.astro.build) is only configured on the maindocsWorker.Fix: Pass
--name docsto always upload preview aliases to the main Worker, regardless of which branch the PR targets.Fixes the broken preview on #14065.